SNOW-1819531: propagate referenced ctes to all root nodes #2670
+63
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
sfc-gh-aalam
requested review from
sfc-gh-smirzaei,
sfc-gh-jdu and
sfc-gh-yixie
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
changed the title
sfc-gh-yzou
reviewed
Nov 27, 2024
| return True | ||
|
|
||
| if isinstance(node, SnowflakePlan) and node.source_plan is not None: | ||
| return node._is_valid_for_replacement |
There was a problem hiding this comment.
i am kind of confused about why we need this function here?
There was a problem hiding this comment.
Can you also add comment for this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1819531
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
i) SNOW-1748140: Modify schema_expression to be structured type aware. #2659 Fix bug where
referenced_ctesis not propagated to root when root source plan is one ofSnowflakeCreateTable,CreateViewCommand,TableUpdate,TableDelete,TableMerge,ConpyIntoLocationNode.ii) fix a bug where
relaxed_pipeline_breakerandis_valid_for_replacementproperties forSnowflakePlanandSelectSnowflakePlanwere not read correctlyiii) updated plan plotter to color nodes that are not valid for replacement with red color.
iv) updated plan plotter to print number of reference a node contains.